Use UBI8 instead of SCL images by yselkowitz · Pull Request #26072 · openshift/origin

yselkowitz · 2021-04-13T18:25:37Z

This allows tests to pass on other architectures, which do not have RHEL
7 and/or CentOS container content.

Goes together with openshift/ruby-hello-world#125

/cc @gabemontero @adambkaplan @soltysh @bparees

openshift-ci-robot · 2021-04-13T18:25:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yselkowitz
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yselkowitz · 2021-04-13T23:36:26Z

As big as this patch is, it seems it's a bit too piecemeal to succeed on its own. Looks like we're going to have to see if anything else can go in independently, otherwise it's just going to be a big branch merge.
/hold

soltysh · 2021-04-14T15:03:46Z

Make sure to have ci/prow/e2e-agnostic-cmd green, it should be fixed by now.

yselkowitz · 2021-05-14T18:51:10Z

This is the complete upstreamable patchset.
/test all

yselkowitz · 2021-06-14T15:15:34Z

/test all

yselkowitz · 2021-06-15T02:24:37Z

openshift/ruby-hello-world#125 has merged
/test all

yselkowitz · 2021-06-15T03:27:55Z

/hold cancel

yselkowitz · 2021-06-15T11:36:20Z

/retest

nodejs-10 is EOL. Also, use UBI8 image for ARM compatibility.

This is a follow-up from commit 1515f0c which removed the resulting file.

Where nodejs-mongodb-example was used, use nodejs-postgresql-example instead.

yselkowitz · 2021-06-22T14:05:12Z

Sigh.
/retest

yselkowitz · 2021-06-22T16:24:23Z

Can anything be done to get this to merge?

gabemontero · 2021-06-22T19:08:46Z

your last run at least failed with another previously reported, non build failure

[sig-instrumentation][Late] Alerts shouldn't report any alerts in firing or pending state apart from Watchdog and AlertmanagerReceiversNotConfigured and have no gaps in Watchdog firing [Suite:openshift/conformance/parallel]

I count 7 bugs associated with it at https://sippy.ci.openshift.org/?release=4.9

all of sig-builds pass

the person who would have to override e2e-gcp-builds to at least get it on the merge queue would be the pillar lead, @bparees ... now, once on the merge queue, tests are reran and you are subject to more flakes

if forced to guess, I would bet he would say you need to search on https://sippy.ci.openshift.org/?release=4.9 and either open bz's for non related failures like this, or the one I cited in #26072 (comment), or go to the existing bz's and post your failures runs, claim you are blocked in there, potentially raise the severity to try and get action sooner, etc. ... invariably it can be an exercise in patience

I'm sure this is of little comfort, but this state of affairs with e2e's is not uncommon for a bit after master branch is opened up for a new release

@bparees @adambkaplan of course please chime in if you see anything that needs to be corrected from your respective points of view with my guidance to @yselkowitz here

openshift-bot · 2021-06-23T08:39:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

yselkowitz · 2021-06-23T12:38:57Z

/retest

yselkowitz · 2021-06-23T14:17:34Z

/retest

yselkowitz · 2021-06-23T16:01:04Z

/retest

yselkowitz · 2021-06-23T17:36:27Z

/retest

yselkowitz · 2021-06-23T19:33:33Z

Looks like https://bugzilla.redhat.com/show_bug.cgi?id=1975283 is the issue of the day. Sigh...

yselkowitz · 2021-06-23T20:55:01Z

Filed openshift/kubernetes#825 as a first step, will then need to be revendored in origin.

yselkowitz · 2021-06-23T21:04:39Z

Filed #26264 as a draft to confirm the fix. Could I get some help with these please?

openshift-bot · 2021-06-24T11:28:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-24T11:40:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-06-24T13:11:47Z

@yselkowitz: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-disruptive	`77d1a9f`	link	`/test e2e-aws-disruptive`
ci/prow/e2e-gcp-disruptive	`77d1a9f`	link	`/test e2e-gcp-disruptive`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gabemontero · 2021-06-24T13:35:34Z

Filed #26264 as a draft to confirm the fix. Could I get some help with these please?

There is a fairly strict process around propagating upstream k8s fixes down the openshift @yselkowitz

There happens to be a active email thread in aos-devel http://mailman-int.corp.redhat.com/archives/aos-devel/2021-June/msg00108.html that was initiated by @soltysh where he provides a bunch of detail and lists a bunch of links explaining it. I personally have never done it so that is about as far as I'm comfortable going wrt coaching.

Reaching out to @soltysh or the folks over at #forum-apiserver are probably your best source for help.

On the plus side, you did get a e2e-gcp-builds that was able to avoid https://bugzilla.redhat.com/show_bug.cgi?id=1975283 ... at least there is some proof there.

yselkowitz · 2021-06-24T14:12:11Z

I'm not surprised, and I wasn't relishing the thought, but it is the natural conclusion of the advice you provided above. All I really want to do here is get THIS merged now in order to meet the deadlines that my team is under.

gabemontero · 2021-06-24T14:23:53Z

I'm not surprised, and I wasn't relishing the thought, but it is the natural conclusion of the advice you provided above. All I really want to do here is get THIS merged now in order to meet the deadlines that my team is under.

Understood.

fwiw I do see that https://bugzilla.redhat.com/show_bug.cgi?id=1975283 is on the agenda of the "OpenShift Mid-Sprint Check-in" on the aos main calendar at noon eastern today (https://docs.google.com/document/d/1ZC8LIEKohhiVN5i9nW-fWfLw37giyUUKoLyQfpe_CcI/edit#)

google meet invite https://meet.google.com/pif-yqnk-aus?authuser=0&hs=122

mfojtik · 2021-06-24T16:54:41Z

/retest

mfojtik · 2021-06-24T16:56:01Z

/override ci/prow/e2e-gcp

This is known failure and it is unrelated to this change.

openshift-ci · 2021-06-24T16:57:25Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-gcp

This is known failure and it is unrelated to this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akram

This test relies on pulling yaml from github rather than from bindata, which makes it difficult to pre-commit testing of changes which affect it. @akram and @gabemontero will move this to the jenkins client plugin E2E, but in the meantime, we comment it out. openshift#26072 (comment)

@akram

This test relies on pulling yaml from github rather than from bindata, which makes it difficult to pre-commit testing of changes which affect it. @akram and @gabemontero will move this to the jenkins client plugin E2E, but in the meantime, we comment it out. openshift#26072 (comment)

@akram

This test relies on pulling yaml from github rather than from bindata, which makes it difficult to pre-commit testing of changes which affect it. @akram and @gabemontero will move this to the jenkins client plugin E2E, but in the meantime, we comment it out. openshift#26072 (comment)

openshift-ci-robot requested review from adambkaplan, bparees, gabemontero and soltysh April 13, 2021 18:25

yselkowitz force-pushed the ubi8 branch from d21f7fa to 78b5fc7 Compare April 13, 2021 19:13

gabemontero mentioned this pull request Apr 13, 2021

Use ubi8/ruby-27 openshift/ruby-hello-world#125

Merged

yselkowitz force-pushed the ubi8 branch from 78b5fc7 to abf989a Compare April 13, 2021 22:10

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2021

yselkowitz force-pushed the ubi8 branch from abf989a to 77d1a9f Compare May 14, 2021 18:49

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021

yselkowitz added 10 commits June 15, 2021 15:44

builds: update nodejs in pullsecret test

65a633f

nodejs-10 is EOL. Also, use UBI8 image for ARM compatibility.

Drop RHEL imagestreams from update-external-examples.sh

ea240b3

This is a follow-up from commit 1515f0c which removed the resulting file.

Drop mongodb from external examples

4ea9e6c

Where nodejs-mongodb-example was used, use nodejs-postgresql-example instead.

Update external examples

ba61136

cluster: sync quickstarts

b364dbd

cluster: switch from nodejs-mongodb to nodejs-postgresql

99788e3

deployments: switch deployment-example from mongodb to postgresql

6616e7c

builds: move multi-namespace-template from mongodb to mariadb

9b8eeaf

jenkins: move pipeline tests from mongodb to mariadb

78afa4f

image_ecosystem: do not wait for mongodb imagestream

b08b0e9

mfojtik merged commit 76a7dfb into openshift:master Jun 24, 2021

yselkowitz deleted the ubi8 branch June 24, 2021 16:58

yselkowitz mentioned this pull request Jun 25, 2021

jenkins: use port 3306 for mariadb #26268

Closed

gabemontero mentioned this pull request Jun 25, 2021

Bug 1976753: move jenkins e2e's that were using mongodb, then mariadb, to postgresql, to get them to pass again #26274

Merged

yselkowitz mentioned this pull request Jun 28, 2021

builds: comment out RHEL-only sample-pipeline template test #26278

Merged

yselkowitz mentioned this pull request Jul 1, 2021

Update quickstart examples and re-run make update #26300

Merged

ingvagabund mentioned this pull request Jul 30, 2024

WRKLDS-1431: e2e: migrate DCs to Deployments #28957

Merged

Comments

Conversation

yselkowitz commented Apr 13, 2021

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

yselkowitz commented Apr 13, 2021

Uh oh!

soltysh commented Apr 14, 2021

Uh oh!

yselkowitz commented May 14, 2021

Uh oh!

yselkowitz commented Jun 14, 2021

Uh oh!

yselkowitz commented Jun 15, 2021

Uh oh!

yselkowitz commented Jun 15, 2021

Uh oh!

yselkowitz commented Jun 15, 2021

Uh oh!

yselkowitz commented Jun 22, 2021

Uh oh!

yselkowitz commented Jun 22, 2021

Uh oh!

gabemontero commented Jun 22, 2021

Uh oh!

openshift-bot commented Jun 23, 2021

Uh oh!

yselkowitz commented Jun 23, 2021

Uh oh!

yselkowitz commented Jun 23, 2021

Uh oh!

yselkowitz commented Jun 23, 2021

Uh oh!

yselkowitz commented Jun 23, 2021

Uh oh!

yselkowitz commented Jun 23, 2021

Uh oh!

yselkowitz commented Jun 23, 2021

Uh oh!

yselkowitz commented Jun 23, 2021

Uh oh!

openshift-bot commented Jun 24, 2021

Uh oh!

openshift-bot commented Jun 24, 2021

Uh oh!

openshift-ci bot commented Jun 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabemontero commented Jun 24, 2021

Uh oh!

yselkowitz commented Jun 24, 2021

Uh oh!

gabemontero commented Jun 24, 2021

Uh oh!

mfojtik commented Jun 24, 2021

Uh oh!

mfojtik commented Jun 24, 2021

Uh oh!

openshift-ci bot commented Jun 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

openshift-ci bot commented Jun 24, 2021 •

edited

Loading